Skip to content

pml/ucx: ignore request leak by default, override by mca param#8661

Merged
yosefe merged 1 commit intoopen-mpi:masterfrom
yosefe:topic/pml-ucx-ignore-request-leak-by-default
Mar 22, 2021
Merged

pml/ucx: ignore request leak by default, override by mca param#8661
yosefe merged 1 commit intoopen-mpi:masterfrom
yosefe:topic/pml-ucx-ignore-request-leak-by-default

Conversation

@yosefe
Copy link
Contributor

@yosefe yosefe commented Mar 19, 2021 •
edited
Loading

Use the API exposed by openucx/ucx#6232, to align with other transports in OpenMPI and not complain about leaks of non-blocking MPI requests.

Example of MPI program:

#include <mpi.h>

int main(int argc, char**argv) {
   MPI_Request req;
   int i = 0;

   MPI_Init(&argc, &argv);
   MPI_Irecv(&i, 1, MPI_INT, 0, 0, MPI_COMM_WORLD, &req); // not waited
   return MPI_Finalize();
}

Behavior before this PR:

$ mpirun -n 1 ./a.out 
[1616177111.163179] [host:128963:0]           mpool.c:44   UCX  WARN  object 0x155cec0 was not returned to mpool ucp_requests

@yosefe
pml/ucx: ignore request leak by default, override by mca param
6672d07 
Signed-off-by: Yossi Itigin <yosefe@mellanox.com>
@yosefe yosefe force-pushed the topic/pml-ucx-ignore-request-leak-by-default branch from 9ee96e9 to 6672d07 Compare March 19, 2021 18:06
@yosefe yosefe requested a review from hoopoepg March 20, 2021 10:46
@open-mpi open-mpi deleted a comment from yosefe Mar 22, 2021
@yosefe yosefe merged commit 3f746fe into open-mpi:master Mar 22, 2021
@yosefe yosefe deleted the topic/pml-ucx-ignore-request-leak-by-default branch March 22, 2021 22:16
This was referenced Mar 25, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brminich brminich brminich approved these changes

@hoopoepg hoopoepg Awaiting requested review from hoopoepg

+1 more reviewer

@gpaulsen gpaulsen gpaulsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Target: main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yosefe @gpaulsen @brminich